Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide delete facility option for users who dont have access #6953

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Hide delete facility option for users who dont have access #6953

merged 5 commits into from
Jan 4, 2024

Conversation

Pranshu1902
Copy link
Contributor

Proposed Changes

Admin View:
image

Non admin view:
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Pranshu1902 Pranshu1902 requested a review from a team as a code owner December 30, 2023 11:57
@vercel Vercel
Copy link

vercel bot commented Dec 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2024 5:28pm

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ad3a27b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6592f5fef82e5c00086bd1b7
😎 Deploy Preview https://deploy-preview-6953--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pranshu1902 @rithviknishad
refactor
17aeabc 
Co-authored-by: Rithvik Nishad <[email protected]>
rithviknishad
rithviknishad reviewed Jan 1, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the lint checks and cypress tests are failing

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Jan 1, 2024 •
edited
Loading

Fixed cypress and lint tests ✔️

@nihal467
Copy link
Member

nihal467 commented Jan 4, 2024

LGTM

@khavinshankar khavinshankar merged commit ff271f8 into ohcnetwork:develop Jan 4, 2024
36 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

@Pranshu1902 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide the Delete Facility for user who don't have access to do it
4 participants
@Pranshu1902 @nihal467 @rithviknishad @khavinshankar