Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DOB Date Format in Patient details page #6950

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

AdityyaX
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Screenshot

Screenshot 2023-12-30 at 10 18 52 AM

made the requested changes @rithviknishad

@AdityyaX AdityyaX requested a review from a team as a code owner December 30, 2023 04:50
Copy link

netlify bot commented Dec 30, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e0117cc
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/659a2760fcd6870008467532
😎 Deploy Preview https://deploy-preview-6950--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Dec 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2024 4:24am

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice attempt, but we already have a reusable utility function called: formatDate that does this for you.

src/Components/Patient/PatientHome.tsx Outdated Show resolved Hide resolved
src/Components/Patient/PatientHome.tsx Outdated Show resolved Hide resolved
@AdityyaX
Copy link
Contributor Author

@rithviknishad
Okay i have made the suggested changes

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you've imported the required method?

Copy link

github-actions bot commented Jan 7, 2024

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 7, 2024
@nihal467 nihal467 changed the title date format changed Updated DOB Date Format in Patient details page Jan 10, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit cc38860 into ohcnetwork:develop Jan 10, 2024
37 of 38 checks passed
Copy link

@AdityyaX We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change DOB(date) Format in Patient Details Page
4 participants