Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes not found errors in investigation and other type errors #6948

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Facility ID and Patient ID were missing from ConsultationTabProps.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner December 29, 2023 17:22
Copy link

netlify bot commented Dec 29, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bcdf3f3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/658f0069c28c140008358ff9
😎 Deploy Preview https://deploy-preview-6948--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2023 5:22pm

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Dec 29, 2023
Copy link

cypress bot commented Dec 29, 2023

Passing run #1795 ↗︎

0 95 0 0 Flakiness 0

Details:

fixes not found errors in investigation and other type errors
Project: CARE Commit: bcdf3f3474
Status: Passed Duration: 02:12 💡
Started: Dec 29, 2023 5:26 PM Ended: Dec 29, 2023 5:28 PM

Review all test suite changes for PR #6948 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 096905d into develop Dec 29, 2023
40 checks passed
@khavinshankar khavinshankar deleted the fix-missing-slugs-in-consultation branch December 29, 2023 17:50
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants