Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the draft feature in the doctor's notes #6932

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

shramanpaul
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

care_fe2.mp4

continuing from PR #6913

made the requested changes @rithviknishad

@shramanpaul shramanpaul requested a review from a team as a code owner December 27, 2023 16:07
Copy link

vercel bot commented Dec 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 2:56pm

Copy link

netlify bot commented Dec 27, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 15f80d7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65902f6615aa400008ba8437
😎 Deploy Preview https://deploy-preview-6932--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the draft is not specific to a consultation

@shramanpaul
Copy link
Contributor Author

shramanpaul commented Dec 28, 2023

the draft is not specific to a consultation

Thank you for your feedback! Could you please provide more details or guidance on what you mean by 'the draft is not specific to a consultation'? @rithviknishad

@rithviknishad
Copy link
Member

let's say you've typed a message and not posted for consultation A of patient A.

you've opened consultation B of patient B, and this would end up restoring the draft of consultation A, right?

the local storage key/value is not uniquely identifying which consultation it belongs to

@shramanpaul
Copy link
Contributor Author

shramanpaul commented Dec 28, 2023

Thank you for the clarification. I have made the draft specific to consultation @rithviknishad

care_fe_consultation.mp4

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its better to keep it consultation-specific rather than patient-specific since a patient can have multiple consultations.

@rithviknishad rithviknishad mentioned this pull request Dec 30, 2023
@shramanpaul
Copy link
Contributor Author

Ok @rithviknishad I will be making the changes to the PR today

made it consultation specific

Co-authored-by: Rithvik Nishad <[email protected]>
@nihal467
Copy link
Member

nihal467 commented Jan 1, 2024

LGTM

@khavinshankar khavinshankar merged commit 15fd7fe into ohcnetwork:develop Jan 4, 2024
28 of 36 checks passed
Copy link

github-actions bot commented Jan 4, 2024

@shramanpaul We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient Notes UX improvement
4 participants