Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Bed Management to useQuery and move pagination state to query params #6909

Merged
merged 8 commits into from
Dec 28, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link

netlify bot commented Dec 25, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 671292b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/658d20a9a5a9c40008c95ad1
😎 Deploy Preview https://deploy-preview-6909--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Dec 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 7:16am

@rithviknishad rithviknishad changed the title Migrate Bed Management to useQuery Migrate Bed Management to useQuery and move pagination state to query params Dec 25, 2023
Copy link

cypress bot commented Dec 25, 2023

Passing run #1787 ↗︎

0 95 0 0 Flakiness 0

Details:

Migrate Bed Management to `useQuery` and move pagination state to query params
Project: CARE Commit: 671292ba60
Status: Passed Duration: 02:25 💡
Started: Dec 28, 2023 7:29 AM Ended: Dec 28, 2023 7:31 AM

Review all test suite changes for PR #6909 ↗︎

@nihal467
Copy link
Member

LGTM

Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 28, 2023
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Dec 28, 2023
@khavinshankar khavinshankar merged commit 8a9234f into develop Dec 28, 2023
37 of 38 checks passed
@khavinshankar khavinshankar deleted the replace-useQuery/bed-mgmt branch December 28, 2023 08:31
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Ashesh3 pushed a commit that referenced this pull request Jan 2, 2024
…ry params (#6909)

* fixes #6906; migrate Bed Management to `useQuery`

* uncommented related test

* handle the auto-fill delay

* handle the google map delay

* revert vite

---------

Co-authored-by: Mohammed Nihal <[email protected]>
Co-authored-by: Khavin Shankar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Parameter in facility bed pagination is not shown
3 participants