Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mispositioned active link indicator #6880

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Fix mispositioned active link indicator #6880

merged 3 commits into from
Dec 28, 2023

Conversation

Omkar76
Copy link
Contributor

@Omkar76 Omkar76 commented Dec 20, 2023 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

30px
image

12px
image

indicator-.4.webm

@Omkar76 Omkar76 requested a review from a team as a code owner December 20, 2023 08:14
@vercel Vercel
Copy link

vercel bot commented Dec 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2023 3:26pm

@netlify Netlify
Copy link

netlify bot commented Dec 20, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e32b7d6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65884d5f2cd6e3000815f3ef
😎 Deploy Preview https://deploy-preview-6880--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Omkar76
Copy link
Contributor Author

Omkar76 commented Dec 20, 2023 •
edited
Loading

Video upload is failing. I'll update description with video recording later. Edit: Done.

@nihal467
Copy link
Member

@Omkar76 marking it for discussion, the link width is increased, which seems a little bit weird to me, for taking others opinion

@Omkar76 Omkar76 force-pushed the link-indicator-resp branch from d8f655e to 4790327 Compare December 24, 2023 14:06
@Omkar76
Copy link
Contributor Author

Omkar76 commented Dec 24, 2023

As discussed, changes have been made so as to not affect height of indicator at default fonts. I've added video to show the same. height of indicator is relative to link. It takes 26% of height of link and is vertically centered.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 988e383 into ohcnetwork:develop Dec 28, 2023
27 of 28 checks passed
@github-actions GitHub Actions
Copy link

@Omkar76 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Ashesh3 pushed a commit that referenced this pull request Jan 2, 2024
@Omkar76 @Ashesh3
Fix mispositioned active link indicator (#6880)
4753a68 
* Fix mispositioned active link indicator

* Make indicator height 26% of link element height.

* Extract 'navItemCount' as variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar link indicator is misplaced if font size is other than default one.
4 participants
@Omkar76 @nihal467 @khavinshankar @rithviknishad