Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily Rounds: fix buggy copy from previous log update #6872

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Daily Rounds: fix buggy copy from previous log update #6872

merged 3 commits into from
Dec 15, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 15, 2023 •
edited by ghost
Loading

WHAT

🤖[deprecated] Generated by Copilot at a273d25

Fixed a bug in the daily rounds form where the clone_last option was always checked. Changed the initial value of clone_last to null and updated it based on user input in DailyRounds.tsx.

Proposed Changes

  • daily rounds, clone last default to null

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at a273d25

  • Fixed a bug where the clone last option was always checked by default in the daily rounds form (link)

@rithviknishad rithviknishad requested a review from a team as a code owner December 15, 2023 11:15
@vercel Vercel
Copy link

vercel bot commented Dec 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 0:22am

@netlify Netlify
Copy link

netlify bot commented Dec 15, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c846a61
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/657c44ccb70fb5000851d7c4
😎 Deploy Preview https://deploy-preview-6872--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Dec 15, 2023 •
edited
Loading

Passing run #1730 ↗︎

0 91 0 0 Flakiness 0

Details:

daily rounds, clone last default to null
Project: CARE Commit: c846a617f8
Status: Passed Duration: 02:10 💡
Started: Dec 15, 2023 12:25 PM Ended: Dec 15, 2023 12:27 PM

Review all test suite changes for PR #6872 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 1f5ea20 into develop Dec 15, 2023
38 checks passed
@github-actions GitHub Actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@rithviknishad rithviknishad changed the title daily rounds, clone last default to null Daily Rounds: fix buggy copy from previous log update Dec 18, 2023
Ashesh3 added a commit that referenced this pull request Dec 26, 2023
@Ashesh3
Revert #6872
dd4181e
@Ashesh3 Ashesh3 mentioned this pull request Dec 26, 2023
Closed
@rithviknishad rithviknishad deleted the rithviknishad/fix-dailyround-clonelast branch February 19, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rithviknishad @nihal467 @khavinshankar