Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Camera Feed button for patient with no bed assigned. #6868

Merged

Conversation

shyamprakash123
Copy link
Contributor

@shyamprakash123 shyamprakash123 commented Dec 14, 2023

WHAT

🤖[deprecated] Generated by Copilot at adce4da

Fix bugs and improve UI of consultation details component. Prevent unnecessary API call and null value errors in ConsultationDetails/index.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at adce4da

  • Prevent unnecessary API call and errors when bed id is null or undefined by adding a conditional check before dispatching listAssetBeds action (link)
  • Assign default value of false to isCameraAttachedRes if assetRes is null to avoid passing null to setIsCameraAttached function (link)

@shyamprakash123 shyamprakash123 requested a review from a team as a code owner December 14, 2023 16:35
Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2023 0:36am

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6557986
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65882582ba4cb80008dd3207
😎 Deploy Preview https://deploy-preview-6868--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit ce066ce into ohcnetwork:develop Dec 27, 2023
25 of 26 checks passed
Copy link

@shyamprakash123 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Camera Feed button for patient with no bed assigned
4 participants