-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solved the responsiveness issue of Administer medicine Slide-Over #6854
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
the route field is not properly responsive |
@nihal467 What I'm supposed to do now? Should I decrease the width of administration section to some more extent as the prescription card can't be altered being a reusable component? Please give some clarification about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increase the width of the slideover a bit more, that should solve it right?
Instead of 1300px, we can go 1400px maybe?
@rithviknishad You can see that the slide-over is covering whole screen. If I increase the width of slide-over then the user have to slide left and right to see the slide-over content completely. Is it ok doing so? |
Select for administration section can come below the prescriptions detail card whenever there is not enough screen space. |
@nihal467 Is it OK if I do overflow hidden for these boxes content as I have seen the same thing on some other pages too. |
@nihal467 A friendly reminder. Please let me know if I can move ahead with this solution and commit the changes. |
I don't think it's okay to hide information (especially in a reusable component where that is the only component that shows the detailed view of the prescription). Was there any issues in achieving the following?
|
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr. |
Hey @rithviknishad please reopen this issue. I was in bad health conditions so couldn't give it time again. I am looking forward to work on this and raise a pr again |
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr. |
WHAT
Solved the responsiveness issue of Administer medicine Slide-Over
Proposed Changes
From:
To :
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖[deprecated] Generated by Copilot at dd24fca