Sort wards by ward number in filters + adds utility method: compareBy

[rithviknishad]

WHAT

🤖[deprecated] Generated by Copilot at b9637f3

The pull request refactors and improves the code for sorting and displaying data related to diagnoses, external results, facilities, and patients. It uses consistent and imported types, and a common utility function compareByKey for sorting arrays of objects by a given key. It affects the files LegacyDiagnosesList.tsx, ListFilter.tsx, ResultUpdate.tsx, FacilityCreate.tsx, RangeAutocompleteFormField.tsx, PatientRegister.tsx, models.tsx, and utils.ts.

Proposed Changes

• Fixes Sort Wards list based on numeric order instead of character code order #6847
• Adds utility method: compareBy that returns a comparator function that operates on the value of an object specified by the key

const sortedItems = items.toSorted(compareBy("quantity"));
// equivalent to:
const sortedItems = items.toSorted((a, b) => a["quantity"] < b["quantity"] ? -1 : a["quantity"] > b["quantity"] ? 1 : 0);


items.sort(compareBy("quantity"));
// equivalent to:
items.sort((a, b) => a["quantity"] < b["quantity"] ? -1 : a["quantity"] > b["quantity"] ? 1 : 0);

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

HOW

🤖[deprecated] Generated by Copilot at b9637f3

• Import and use compareByKey function for sorting arrays of objects by a given key in various components (link, link, link, link, link, link, link, link, link, link, link)
• Refactor and type wardList, lsgList, wards, and selectedLsgs state variables and props in ListFilter.tsx using WardModel and LocalBodyModel types (link, link, link)
• Simplify and enhance MultiSelectFormField components for local_bodies and wards in ListFilter.tsx by using optionDescription prop and removing unnecessary wrappers and functions (link, link, link)
• Modify WardModel interface in models.tsx to include panchayath and local_body_id fields and use LocalBodyModel["id"] type (link)
• Type states, districts, localBodies, and ward state variables and props in FacilityCreate.tsx using StateModel, DistrictModel, LocalBodyModel, and WardModel types and remove unused interfaces (link, link, link)
• Add compareByKey function to utils.ts as a utility function for sorting arrays of objects by a given key (link)

[netlify]

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	c2c8a96
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/657aca4c176648000830c688
😎 Deploy Preview	https://deploy-preview-6852--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 14, 2023 9:27am

[cypress]

Passing run #1719 ↗︎

0

91

0

0

0

Details:

Sort wards by ward number in filters + adds utility method: `compareBy`
Project: CARE	Commit: c2c8a96edc
Status: Passed	Duration: 02:40 💡
Started: Dec 14, 2023 9:48 AM	Ended: Dec 14, 2023 9:51 AM

Review all test suite changes for PR #6852 ↗︎

[nihal467]

LGTM

[github-actions]

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.