-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide "Asset Type" #6835
Hide "Asset Type" #6835
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Cypress Tests are now fixed. |
@shyamprakash123 fix the failing cypress test, you should be fixing cypress with running care in the local frontend and backend by loading dummy data |
f1ee5b7
to
f222760
Compare
@nihal467 I reverted the cypress test variables, can you re-test this? |
The cypress test still seems to be failing, could you look into it? |
@shyamprakash123 fix the cypress issue |
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr. |
👋 Hi, @shyamprakash123, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
4408f8c
to
69689b8
Compare
WHAT
🤖[deprecated] Generated by Copilot at be3b8e2
This pull request removes the asset type feature from the frontend components that deal with assets. The asset type is no longer a relevant attribute for filtering, creating, or managing assets, since the backend API only supports internal assets. The affected components are
AssetFilter
,AssetCreate
, andAssetManage
.Proposed Changes
Fixes Hide "Asset Type" (Assets to be always "Internal") #6789
Removed "Asset Type" select input from asset create/edit form.
Upon creating an asset, it is always created with asset type as "Internal" (default)
Removed Asset Type label from the asset details page.
Removed Asset Type filter from Advanced Filters also.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖[deprecated] Generated by Copilot at be3b8e2
AssetFilter
component and the filter logic (link, link, link, link)AssetCreate
component and the asset creation logic (link, link, link, link, link, link)AssetManage
component (link)AssetType.INTERNAL
for creating or editing the assets in theAssetCreate
component (link)