Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow occupancy indicator to resize when default font size changes. #6806

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

Omkar76
Copy link
Contributor

@Omkar76 Omkar76 commented Dec 7, 2023

WHAT

🤖[deprecated] Generated by Copilot at 55d266f

Improved the UI of the facility card component by removing unnecessary CSS classes. This affects the file src/Components/Facility/FacilityCard.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA
Screenshot 2023-12-07 at 2 08 36 PM Screenshot 2023-12-07 at 2 08 22 PM Screenshot 2023-12-07 at 2 07 38 PM

HOW

🤖[deprecated] Generated by Copilot at 55d266f

  • Removed the h-[38px] and my-1 classes from the div and dt elements that show the occupancy percentage of the facility, to improve the alignment and spacing of the button and the tooltip icon (link, link)

@Omkar76 Omkar76 requested a review from a team as a code owner December 7, 2023 08:44
Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 7:34am

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8ced0b6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6572c6da4238a10008cd8897
😎 Deploy Preview https://deploy-preview-6806--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 1a6b3d3 into ohcnetwork:develop Dec 13, 2023
28 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

occupancy indicator in facility card does not resize itself when font size is changed in browser
4 participants