You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the required attribute from the spo2 field in DailyRounds.tsx to allow users to skip it if they do not have a pulse oximeter. This fixes the issue #1729.
Remove the required attribute from the spo2 field in the TextField component (link). This allows the user to leave the field blank if they do not have the spo2 data, as reported in issue added result filter in SampleTest #1729. The file src/Components/Patient/DailyRounds.tsx contains this change.
@konavivekramakrishna After merging your this PR, anyone can perform a standard log update by leaving all fields under 'vital' blank and simply submitting it. This is where the problem arises, as it results in a blank log update.
Based on my recent conversation with Aparna, we don't anticipate any issues from the field, as mentioned above. @konavivekramakrishna, you don't need to make any changes; the PR is good to merge.
Disable Submit button in normal log update #6787 "We need to address an expected bug that, once this PR is merged, so already created a new issue. After that PR is merged, we will proceed to merge this one.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nihal467
added
hold
waiting for related PR
input field
WHAT
🤖[deprecated] Generated by Copilot at eed8215
Removed the
requiredattribute from thespo2field inDailyRounds.tsxto allow users to skip it if they do not have a pulse oximeter. This fixes the issue #1729.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖[deprecated] Generated by Copilot at eed8215
requiredattribute from thespo2field in theTextFieldcomponent (link). This allows the user to leave the field blank if they do not have the spo2 data, as reported in issue added result filter in SampleTest #1729. The filesrc/Components/Patient/DailyRounds.tsxcontains this change.