Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to Location Live Feed #6726

Merged
merged 19 commits into from
Dec 7, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 27, 2023

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e1f6b0d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6570b13f3b74b4000863212b
😎 Deploy Preview https://deploy-preview-6726--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 5:37pm

Copy link

cypress bot commented Nov 27, 2023

Passing run #1691 ↗︎

0 91 0 0 Flakiness 0

Details:

Enhancements to Location Live Feed
Project: CARE Commit: e1f6b0d13f
Status: Passed Duration: 02:11 💡
Started: Dec 6, 2023 5:40 PM Ended: Dec 6, 2023 5:42 PM

Review all test suite changes for PR #6726 ↗︎

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 29, 2023
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Dec 1, 2023
@rithviknishad rithviknishad marked this pull request as ready for review December 4, 2023 12:58
@rithviknishad rithviknishad requested a review from a team as a code owner December 4, 2023 12:58
@rithviknishad rithviknishad added important Major Code Change This Tag represent PR, which will be causing major Code change in the platform labels Dec 4, 2023
@nihal467
Copy link
Member

nihal467 commented Dec 5, 2023

@rithviknishad
image

  • the other camera aren't configured but its still saying loading , so i dont think camera is working filter is working properly

image

  • this is only showing the bed name, not the preset name in the dropdown

image

  • hide camera without patient is malfunctioning as already patient existing bed are been hidden by this filter

https://deploy-preview-6726--care-net.netlify.app/facility/9d2aa814-cc74-4172-bd16-dc80c0a14a80/live-monitoring?location=0c0fa831-6d1d-4f80-8661-3540f7907aed&page=1&limit=9&is_working=true&in_use_by_consultation=
image

  • the feed is keep on refreshing every 2 minute

@rithviknishad
Copy link
Member Author

@nihal467 the is working filter is not whether about whether it is offline or host unreachable. It is about the asset update the working/non working select in the asset form.

@rithviknishad
Copy link
Member Author

@nihal467 the filters in question have been hidden for now. Let's ship this feature out and add the filters in another PR.

Other issues have been fixed.

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2023

@rithviknishad
image

the buttons are not clickable "configuration" and retry

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2023

@rithviknishad fix the above issue and all other things seem perfect

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2023

LGTM

@khavinshankar khavinshankar merged commit 745d4f8 into develop Dec 7, 2023
59 of 60 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/improve-live-feed branch December 7, 2023 04:45
Copy link

github-actions bot commented Dec 7, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Code Change This Tag represent PR, which will be causing major Code change in the platform tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving Live Feed Screen UI
3 participants