-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to Location Live Feed #6726
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #1691 ↗︎
Details:
Review all test suite changes for PR #6726 ↗︎ |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
https://deploy-preview-6726--care-net.netlify.app/facility/9d2aa814-cc74-4172-bd16-dc80c0a14a80/live-monitoring?location=0c0fa831-6d1d-4f80-8661-3540f7907aed&page=1&limit=9&is_working=true&in_use_by_consultation=
|
@nihal467 the is working filter is not whether about whether it is offline or host unreachable. It is about the asset update the working/non working select in the asset form. |
@nihal467 the filters in question have been hidden for now. Let's ship this feature out and add the filters in another PR. Other issues have been fixed. |
the buttons are not clickable "configuration" and retry |
@rithviknishad fix the above issue and all other things seem perfect |
LGTM |
@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist