Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert buggy replacement of useDispatch with useQuery in Live Feed #6707

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 24, 2023

WHAT

🤖[deprecated] Generated by Copilot at 9173898

Refactored the LiveFeed component to use redux for bed presets. This improves the consistency and maintainability of the code and reduces the dependency on the request module. Also cleaned up some imports in LiveFeed.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 9173898

  • Refactor the LiveFeed component to use redux actions for fetching and updating bed presets (link, link, link, link, link)
  • Remove unused imports and reorder imports in LiveFeed.tsx (link)
  • Replace the request module with the listAssetBeds action for getting the bed presets data from the API (link)
  • Replace the request module with the deleteAssetBed action for deleting a bed preset from the API (link)
  • Replace the request module with the partialUpdateAssetBed action for updating a bed preset in the API (link, link)
  • Access the response data and status from the action payload instead of the request object (link, link, link, link)
  • Remove an empty line in LiveFeed.tsx (link)

@rithviknishad rithviknishad requested a review from a team November 24, 2023 05:00
@rithviknishad rithviknishad requested a review from a team as a code owner November 24, 2023 05:00
Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9173898
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65602dfe3018700008105a71
😎 Deploy Preview https://deploy-preview-6707--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Nov 24, 2023 5:00am

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Nov 24, 2023
Copy link

cypress bot commented Nov 24, 2023

1 failed test on run #1608 ↗︎

1 84 0 0 Flakiness 0

Details:

Revert buggy replacement of useDispatch with useQuery in Live Feed
Project: CARE Commit: 9173898926
Status: Failed Duration: 02:07 💡
Started: Nov 24, 2023 5:04 AM Ended: Nov 24, 2023 5:06 AM
Failed  cypress/e2e/patient_spec/patient_manage.cy.ts • 1 failed test

View Output

Test Artifacts
Patient > Post doctor notes for an already created patient Test Replay Screenshots

Review all test suite changes for PR #6707 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 3fe417f into develop Nov 24, 2023
62 of 66 checks passed
@khavinshankar khavinshankar deleted the fix-6706 branch November 24, 2023 06:18
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera Preset created are not shown in asset configure page
3 participants