Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes missing warranty validity filters #6698

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fixes missing warranty validity filters #6698

merged 1 commit into from
Nov 24, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 23, 2023

WHAT

🤖[deprecated] Generated by Copilot at 5b0251d

Added warranty and AMC filters to AssetsList component. The component now accepts two query parameters from the URL to filter the assets by their warranty or AMC end date.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 5b0251d

  • Add warranty and AMC filters to the assets list component (link)

@rithviknishad rithviknishad requested a review from a team November 23, 2023 16:55
@rithviknishad rithviknishad requested a review from a team as a code owner November 23, 2023 16:55
Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5b0251d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/655f841926100f000814aad2
😎 Deploy Preview https://deploy-preview-6698--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Nov 23, 2023 4:55pm

Copy link

cypress bot commented Nov 23, 2023

1 failed test on run #1603 ↗︎

1 84 0 0 Flakiness 0

Details:

fixes missing warranty validity filters
Project: CARE Commit: 5b0251de54
Status: Failed Duration: 02:11 💡
Started: Nov 23, 2023 4:59 PM Ended: Nov 23, 2023 5:01 PM
Failed  cypress/e2e/patient_spec/patient_manage.cy.ts • 1 failed test

View Output

Test Artifacts
Patient > Post doctor notes for an already created patient Test Replay Screenshots

Review all test suite changes for PR #6698 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 6716d2c into develop Nov 24, 2023
62 of 64 checks passed
@khavinshankar khavinshankar deleted the fix-6697 branch November 24, 2023 02:50
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warranty/AMC End of Validity filter is malfunctioning at asset tab
3 participants