Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the external results sample format #6694

Merged
merged 8 commits into from
Dec 6, 2023

Conversation

konavivekramakrishna
Copy link
Contributor

@konavivekramakrishna konavivekramakrishna commented Nov 22, 2023

WHAT

🤖[deprecated] Generated by Copilot at ed80a98

The pull request adds a feature to download the external result template file locally and updates the template file with a sample row of data. It modifies the src/Components/ExternalResult/ExternalResultUpload.tsx, public/config.json, and public/External-Results-Template.csv files.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at ed80a98

  • Add a sample row of data to the external result template file External-Results-Template.csv (link)
  • Modify the config file config.json to store a relative path to the template file instead of a Google Sheets link (link)
  • Create a custom download function handleDownload in the external result upload page ExternalResultUpload.tsx that uses the config value to download the template file locally (link)
  • Replace the anchor element that triggers the download with one that calls the handleDownload function (link)

@konavivekramakrishna konavivekramakrishna requested a review from a team November 22, 2023 16:41
@konavivekramakrishna konavivekramakrishna requested a review from a team as a code owner November 22, 2023 16:41
Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2023 8:08am

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 65f485d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/656ae5d7e4138000084f1d4c
😎 Deploy Preview https://deploy-preview-6694--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@konavivekramakrishna konavivekramakrishna changed the title Modified the existing external results sample format Modified the external results sample format Nov 22, 2023
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@konavivekramakrishna

You'll have to update the configs here too: https://github.com/coronasafe/care_deploy_configs

cc: @sainak

@konavivekramakrishna
Copy link
Contributor Author

konavivekramakrishna commented Nov 24, 2023

@rithviknishad
Copy link
Member

@sainak

public/config.json Outdated Show resolved Hide resolved
handleDownload function in
ExternalResultUpload.tsx
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@konavivekramakrishna just some minor alterations

src/Components/ExternalResult/ExternalResultUpload.tsx Outdated Show resolved Hide resolved
@khavinshankar khavinshankar merged commit dc8dec0 into ohcnetwork:develop Dec 6, 2023
34 of 36 checks passed
@konavivekramakrishna konavivekramakrishna deleted the fix#6649 branch December 6, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the existing external results sample format as it is not working
5 participants