Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Facility Cover Image upload pop-up #6616

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

konavivekramakrishna
Copy link
Contributor

@konavivekramakrishna konavivekramakrishna commented Nov 15, 2023

WHAT

🤖 Generated by Copilot at 2700c58

Refactor edit cover image functionality for facilities. Remove onClick handler from FacilityHome.tsx and use a separate component and button instead.

Proposed Changes

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 2700c58

  • Remove the onClick handler for the facility cover image (link) and replace it with a button that opens the edit cover image modal (

@konavivekramakrishna konavivekramakrishna requested a review from a team November 15, 2023 08:50
@konavivekramakrishna konavivekramakrishna requested a review from a team as a code owner November 15, 2023 08:50
Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 6:31pm

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0116897
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65550e32bd59e300081b9e83
😎 Deploy Preview https://deploy-preview-6616--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 835cab3 into ohcnetwork:develop Nov 21, 2023
35 of 36 checks passed
@rithdick
Copy link

rithdick commented Nov 21, 2023 via email

@konavivekramakrishna konavivekramakrishna deleted the fix#coverimage branch November 21, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility Cover Image upload pop-up is malfunctioning
5 participants