Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clear button for CNS location filter #6581

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Nov 10, 2023

WHAT

🤖 Generated by Copilot at 7cfda46

Fixed a location filter bug and removed a redundant button in the central nursing station component. This improves the usability and performance of the CentralNursingStation.tsx file.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 7cfda46

  • Fix location filter bug by calling removeFilter when location is cleared (link)
  • Remove redundant ButtonV2 component for clearing location filter (link)

@Ashesh3 Ashesh3 requested a review from a team November 10, 2023 07:02
@Ashesh3 Ashesh3 requested a review from a team as a code owner November 10, 2023 07:02
@Ashesh3 Ashesh3 requested a review from vigneshhari November 10, 2023 07:02
Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 8:54am

Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fe8a969
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/654defaaef5ec900087af417
😎 Deploy Preview https://deploy-preview-6581--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 10, 2023

1 failed test on run #1559 ↗︎

1 84 0 0 Flakiness 0

Details:

Fix clear button for CNS location filter
Project: CARE Commit: fe8a9699f7
Status: Failed Duration: 02:50 💡
Started: Nov 10, 2023 8:58 AM Ended: Nov 10, 2023 9:00 AM
Failed  cypress/e2e/users_spec/user_manage.cy.ts • 1 failed test

View
Output

Test Artifacts
Manage User > linking skills for a users and verify its reflection in profile Test Replay Screenshots

Review all test suite changes for PR #6581 ↗︎

@khavinshankar khavinshankar merged commit 8e2148f into develop Nov 10, 2023
55 of 58 checks passed
@khavinshankar khavinshankar deleted the cns-location-selector branch November 10, 2023 09:07
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the separate clear button in view cns page
2 participants