Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort imports and use absolute imports #6557

Closed
wants to merge 9 commits into from
Closed

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Nov 7, 2023

WHAT

🤖 Generated by Copilot at 7eeb6a5

This pull request enhances the linting setup for TypeScript files and simplifies the import paths. It updates the .eslintrc.json and package.json files, and adds an alias for the @ symbol in the vite.config.ts file.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 7eeb6a5

  • Configure eslint to use TypeScript resolver and import plugins (link, link, link, link)
  • Rename lint-fix script to lint:fix in package.json (link)
  • Add alias for @ symbol to point to /src directory in vite.config.ts (link, link)
  • Reorder and format import statements according to eslint rules (link, link, link)
  • Remove extra blank line in .eslintrc.json (link)

@khavinshankar khavinshankar requested a review from a team November 7, 2023 07:43
@khavinshankar khavinshankar requested a review from a team as a code owner November 7, 2023 07:43
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ❌ Failed (Inspect) Nov 7, 2023 0:48am

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e3c4c40
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/654a32046de1e100085cad5e
😎 Deploy Preview https://deploy-preview-6557--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 7, 2023

Passing run #1537 ↗︎

0 82 0 0 Flakiness 0

Details:

Sort imports and use absolute imports
Project: CARE Commit: b6a9c739f5
Status: Passed Duration: 03:08 💡
Started: Nov 7, 2023 12:36 PM Ended: Nov 7, 2023 12:39 PM

Review all test suite changes for PR #6557 ↗︎

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 16, 2023
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Nov 24, 2023
@rithviknishad
Copy link
Member

@khavinshankar maybe we can just merge off the configurations for now, and we can eventually migrate existing files as we go? It won't cause functionality issues right other than eslint errors.

@khavinshankar
Copy link
Member Author

@khavinshankar maybe we can just merge off the configurations for now, and we can eventually migrate existing files as we go? It won't cause functionality issues right other than eslint errors.

I agree

@bodhish bodhish deleted the absolute-imports branch December 1, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict pull requests with merge conflict stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use absolute paths for imports & Introduce Frontend Plugins
2 participants