Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Consultation Diagnosis (M2M relation, additional verification statuses and other improvements) #6528

Merged
merged 27 commits into from
Nov 9, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 31, 2023

WHAT

🤖 Generated by Copilot at be7fe42

This pull request introduces a new diagnosis model and verification workflow for consultations, and updates the existing components and types to use the new model. It also adds new components, types, routes, and translations for handling diagnoses, and removes or modifies some unused or deprecated code and files.

Required Backends

Proposed Changes

image image image image image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at be7fe42

  • Add new components, types, and routes for handling diagnoses with verification statuses (F4, F5, F6, F7, F8, F9, F10)

@rithviknishad rithviknishad requested a review from a team October 31, 2023 07:12
@rithviknishad rithviknishad requested a review from a team as a code owner October 31, 2023 07:12
@vercel
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 10:14am

@netlify
Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2293f40
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/654cb0f44ccb9300085152da
😎 Deploy Preview https://deploy-preview-6528--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Oct 31, 2023

Passing run #1550 ↗︎

0 84 0 0 Flakiness 0

Details:

Refactor Consultation Diagnosis (M2M relation, additional verification statuses ...
Project: CARE Commit: 2293f4084e
Status: Passed Duration: 02:41 💡
Started: Nov 9, 2023 10:17 AM Ended: Nov 9, 2023 10:20 AM

Review all test suite changes for PR #6528 ↗︎

@nihal467
Copy link
Member

Functionality looks good to me @rithviknishad fix the test

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature and removed tested labels Nov 6, 2023
@rithviknishad rithviknishad removed the Cypress Test Pending The Cypress test are to be verified label Nov 6, 2023
@nihal467
Copy link
Member

nihal467 commented Nov 6, 2023

@rithviknishad
image

when iam creating a new consultation, unable to select principle diagnosis

@nihal467
Copy link
Member

nihal467 commented Nov 9, 2023

LGTM

@khavinshankar khavinshankar merged commit f575710 into develop Nov 9, 2023
57 of 58 checks passed
@khavinshankar khavinshankar deleted the consultation_diagnoses_m2m branch November 9, 2023 11:38
Copy link

github-actions bot commented Nov 9, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend cypress passed P1 breaking issue or vital feature tested
Projects
None yet
3 participants