Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cypress Test | Facility Redirection to view user page | User Tab #6513

Merged
merged 7 commits into from
Oct 30, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Oct 28, 2023

WHAT

🤖 Generated by Copilot at c664790

This pull request improves and expands the end-to-end tests for user management features in the care_fe frontend application. It fixes a type error and a redundant test case in user_crud.cy.ts, adds and updates test cases in user_homepage.cy.ts and user_creation.cy.ts, and enhances the page object classes in UserSearch.ts and FacilityCreation.ts. It also adds an id attribute to the FacilityUsers.tsx component to facilitate testing.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at c664790

  • Add a new test file user_creation.cy.ts that verifies the user redirection from the facility page to the user page (link)
  • Fix a type error in the user_crud.cy.ts file by adding quotes around the phone numbers (link)
  • Remove a redundant test case for the next/previous page navigation from the user_crud.cy.ts file (link)
  • Rename the test suite in the user_homepage.cy.ts file to "User Homepage" and add two constants for the phone numbers (link)
  • Add a new test case for the user advance filter functionality in the user_homepage.cy.ts file and verify the URL and the data displayed on the page (link)
  • Add a new test case for the next/previous page navigation in the user_homepage.cy.ts file and verify the URL and the current page number (link)
  • Add a new method to the FacilityPage class in the FacilityCreation.ts file that clicks on the view users option in the manage facility dropdown menu (link)
  • Add a new method to the UserPage class in the UserSearch.ts file that verifies the URL after applying the advance filter (link)
  • Add several new methods to the UserPage class in the UserSearch.ts file that perform various actions and assertions related to the advance filter functionality (link)
  • Add an id attribute to the div element that displays the user name in the FacilityUsers.tsx file (link)

@nihal467 nihal467 requested a review from a team October 28, 2023 13:42
@nihal467 nihal467 requested a review from a team as a code owner October 28, 2023 13:42
@nihal467 nihal467 requested a review from bodhish October 28, 2023 13:42
@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f769d47
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653f71081695530008d06154
😎 Deploy Preview https://deploy-preview-6513--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 9:02am

@cypress
Copy link

cypress bot commented Oct 28, 2023

Passing run #1497 ↗︎

0 87 0 0 Flakiness 0

Details:

New Cypress Test | Facility Redirection to view user page | User Tab
Project: CARE Commit: f769d47600
Status: Passed Duration: 03:55 💡
Started: Oct 30, 2023 9:06 AM Ended: Oct 30, 2023 9:10 AM

Review all test suite changes for PR #6513 ↗︎

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 30, 2023
@github-actions
Copy link

👋 Hi, @nihal467,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 30, 2023
@khavinshankar khavinshankar merged commit fa3b4a7 into develop Oct 30, 2023
30 checks passed
@khavinshankar khavinshankar deleted the user-redirection branch October 30, 2023 09:12
@github-actions
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants