Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loadash-es import #6477

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix loadash-es import #6477

merged 1 commit into from
Oct 20, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 19, 2023

WHAT

🤖 Generated by Copilot at 3f110dc

This pull request introduces the lodash-es library to various components and files in the coronasafe/care_fe repository. The main purpose is to improve the code readability, structure, performance, and user interface by using the lodash-es functions for formatting, accessing, and manipulating data. The pull request also refactors some imports and usages of the Notification and chain modules.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 3f110dc

  • Simplify imports of lodash-es functions and use the _ module consistently (link, link, link, link, link, link, link, link)
  • Prefix lodash-es functions with _ to avoid naming conflicts and maintain consistency (link, link, link, link, link)
  • Format error messages, statuses, results, and names using _.startCase and _.camelCase to improve user interface and experience (link, link, link, link, link, link, link)
  • Add optional chaining operators to patientData object to prevent errors and crashes (link)
  • Move import of Notification module from Reports/index.tsx to ExternalResultUpload.tsx to use it for external result upload feature (link)

@Ashesh3 Ashesh3 requested a review from a team October 19, 2023 18:23
@Ashesh3 Ashesh3 requested a review from a team as a code owner October 19, 2023 18:23
@Ashesh3 Ashesh3 requested a review from bodhish October 19, 2023 18:23
@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 6:23pm

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3f110dc
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65317414dbaccf0008de3870
😎 Deploy Preview https://deploy-preview-6477--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Oct 19, 2023

Passing run #1441 ↗︎

0 79 0 0 Flakiness 0

Details:

Fix loadash-es import
Project: CARE Commit: 3f110dc173
Status: Passed Duration: 03:34 💡
Started: Oct 19, 2023 6:27 PM Ended: Oct 19, 2023 6:31 PM

Review all test suite changes for PR #6477 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 08193ba into develop Oct 20, 2023
36 checks passed
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the loadash-fix branch October 20, 2023 01:05
Ashesh3 added a commit that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigation Table and Sample Details page is crashing
3 participants