Fix: Asset tab facility and location badges are malfunctioning #6474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rithviknishad
requested changes
Oct 19, 2023
rithviknishad
requested changes
Oct 19, 2023
Co-authored-by: Rithvik Nishad <[email protected]>
rithviknishad
requested changes
Oct 25, 2023
rithviknishad
approved these changes
Oct 26, 2023
|
LGTM |
khavinshankar
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 91b364d
This pull request improves the user interface and functionality of the assets list component. It adds state variables to show the facility name and location in the filter section, and uses the
useQueryhook to refetch data based on filter changes.Proposed Changes
http://127.0.0.1:4000/assets?page=1&limit=18&facility=df1a22fb-1875-4949-af85-15d1917b8bfd&asset_type=&asset_class=&status=&location=&warranty_amc_end_of_validity_before=&warranty_amc_end_of_validity_after=
Remove the facility and location filter when the cross is clicked
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 91b364d
facility_locationto store and display the location name of the selected facility in the assets list (link, link, link)facility_nameto store and display the facility name of the selected facility in the assets list (link)locationtolocationDatato avoid confusion withfacility_locationinAssetsList.tsx(link)refetchOnUpdateto theQueryOptionsinterface inuseQuery.tsto allow refetching the query data when the query parameters change (link)refetchOnUpdateoption in the query to get the facility asset location inAssetsList.tsxto update the location name when the facility changes (link, link)