Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session expiry detection #6472

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Fix session expiry detection #6472

merged 2 commits into from
Oct 20, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 19, 2023

WHAT

🤖 Generated by Copilot at 5c30cab

Added a check for access token before API calls in fireRequest.tsx. Redirected users to a session expired page if the token is missing.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 5c30cab

  • Add a check for the access token in the local storage before setting the authorization header for the API call (link)

@Ashesh3 Ashesh3 requested a review from a team October 19, 2023 08:05
@Ashesh3 Ashesh3 requested a review from a team as a code owner October 19, 2023 08:05
@Ashesh3 Ashesh3 requested a review from mathew-alex October 19, 2023 08:05
@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ae4db1b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6530ef3185f71b0008145ca9
😎 Deploy Preview https://deploy-preview-6472--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 8:56am

@cypress
Copy link

cypress bot commented Oct 19, 2023

Passing run #1439 ↗︎

0 79 0 0 Flakiness 0

Details:

Fix session expiry detection
Project: CARE Commit: ae4db1b90a
Status: Passed Duration: 03:37 💡
Started: Oct 19, 2023 9:01 AM Ended: Oct 19, 2023 9:05 AM

Review all test suite changes for PR #6472 ↗︎

@nihal467
Copy link
Member

@Ashesh3
image

when i sign out, i have been redirected to session expired page

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 19, 2023

@Ashesh3 image

when i sign out, i have been redirected to session expired page

Should be fixed now.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 33f103d into develop Oct 20, 2023
29 checks passed
@khavinshankar khavinshankar deleted the session-expire-fix branch October 20, 2023 01:06
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Ashesh3 added a commit that referenced this pull request Oct 20, 2023
* fix session expiry detection

* Fix logout bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session expired page is malfunctioning
3 participants