Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes JWT token refresh interval default fallback to 5 mins (instead of 15 mins) #6466

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 18, 2023

WHAT

🤖 Generated by Copilot at d54ce49

Reduced the JWT token refresh interval to prevent authentication errors. Changed the setInterval function in src/Providers/AuthUserProvider.tsx to use a variable or a default value of 5 minutes.

Proposed Changes

  • Fixes JWT token refresh interval default fallback to 5 mins (instead of 15 mins)

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at d54ce49

  • Reduce the interval for refreshing the JWT token to 5 minutes or the value of jwt_token_refresh_interval (link). This prevents the token from expiring and causing authentication errors.

@rithviknishad rithviknishad requested a review from a team October 18, 2023 09:16
@rithviknishad rithviknishad requested a review from a team as a code owner October 18, 2023 09:16
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 9:17am

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4d8fc74
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/652fa29ef219b20008150c6f
😎 Deploy Preview https://deploy-preview-6466--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Oct 18, 2023
@cypress
Copy link

cypress bot commented Oct 18, 2023

Passing run #1429 ↗︎

0 79 0 0 Flakiness 0

Details:

Fixes JWT token refresh interval default fallback to 5 mins (instead of 15 mins)
Project: CARE Commit: 4d8fc74765
Status: Passed Duration: 03:40 💡
Started: Oct 18, 2023 9:24 AM Ended: Oct 18, 2023 9:28 AM

Review all test suite changes for PR #6466 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit db52839 into develop Oct 18, 2023
27 of 29 checks passed
@khavinshankar khavinshankar deleted the fix-token-refresh-fallback branch October 18, 2023 11:39
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Ashesh3 pushed a commit that referenced this pull request Oct 20, 2023
…of 15 mins) (#6466)

* fix JWT token refresh fallback interval

* remove jwt_token_refresh_interval from `config.json`
Ashesh3 pushed a commit that referenced this pull request Oct 23, 2023
…of 15 mins) (#6466)

* fix JWT token refresh fallback interval

* remove jwt_token_refresh_interval from `config.json`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants