Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced useDispatch w. useQuery/request: Resource (src/Components/Resource/**) #6461

Merged
merged 18 commits into from
Oct 31, 2023

Conversation

konavivekramakrishna
Copy link
Contributor

@konavivekramakrishna konavivekramakrishna commented Oct 17, 2023

WHAT

🤖 Generated by Copilot at 47daa24

Refactored the resource management components to use the useQuery and request utilities for data fetching and posting, instead of custom hooks and actions. Removed unused and updated existing routes and functions in the api and actions modules. Added type interfaces for the comment and resource data models in the models.ts file.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 47daa24

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 11:59am

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f4b61c2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653e48ea3814170008a69c34
😎 Deploy Preview https://deploy-preview-6461--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@konavivekramakrishna
Copy link
Contributor Author

konavivekramakrishna commented Oct 17, 2023

comment section in paginaltedList pagination is not working, will paginated list itself handle the query offset and limit or explicitly change it
Apart from that are there any changes required?

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 18, 2023
@github-actions
Copy link

👋 Hi, @konavivekramakrishna,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@konavivekramakrishna konavivekramakrishna marked this pull request as ready for review October 19, 2023 06:30
@konavivekramakrishna konavivekramakrishna requested a review from a team October 19, 2023 06:30
@konavivekramakrishna konavivekramakrishna requested a review from a team as a code owner October 19, 2023 06:30
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 19, 2023
src/Components/Resource/BadgesList.tsx Outdated Show resolved Hide resolved
src/Components/Resource/BadgesList.tsx Outdated Show resolved Hide resolved
src/Components/Resource/BadgesList.tsx Outdated Show resolved Hide resolved
src/Components/Resource/CommentSection.tsx Outdated Show resolved Hide resolved
src/Components/Resource/ListFilter.tsx Show resolved Hide resolved
src/Components/Resource/models.ts Outdated Show resolved Hide resolved
src/Components/Resource/models.ts Outdated Show resolved Hide resolved
src/Components/Resource/models.ts Outdated Show resolved Hide resolved
src/Components/Resource/models.ts Outdated Show resolved Hide resolved
@konavivekramakrishna
Copy link
Contributor Author

@rithviknishad
changed everything according to review but except removing
const [assignedUser, SetAssignedUser] = useState<UserModel>();
as removing it casues unable to change and clear option

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 26, 2023
src/Components/Resource/BadgesList.tsx Outdated Show resolved Hide resolved
src/Components/Resource/BadgesList.tsx Outdated Show resolved Hide resolved
@rithviknishad
Copy link
Member

Rest LGTM

@konavivekramakrishna
Copy link
Contributor Author

@nihal467
there is a minor issue with the filtering, and I will fix by today.

@konavivekramakrishna
Copy link
Contributor Author

konavivekramakrishna commented Oct 29, 2023

Hello @rithviknishad
Could you please review

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 6746359 into ohcnetwork:develop Oct 31, 2023
29 checks passed
@konavivekramakrishna konavivekramakrishna deleted the fix#6443 branch October 31, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠️ Replace useDispatch w. useQuery/request: Resource (src/Components/Resource/**)
4 participants