-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for webrtc stream #6457
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
20 failed tests on run #1431 ↗︎
Details:
patient_spec/patient_crud.cy.ts • 1 failed test
assets_spec/assets_creation.cy.ts • 1 failed test
users_spec/user_crud.cy.ts • 2 failed tests
assets_spec/assets_manage.cy.ts • 1 failed test
facility_spec/facility.cy.ts • 1 failed test
The first 5 failed specs are shown, see all 19 specs in Cypress Cloud. Review all test suite changes for PR #6457 ↗︎ |
👋 Hi, @sainak, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@sainak most of the cypress are failing, can you check it |
👋 Hi, @sainak, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
comment from @sainak : this pr is blocked, we need to asses the benefits of webrtc over existing services |
Closing this PR due to lack of recent progress. @sainak ping me if you are planing to work on this. |
WHAT
🤖 Generated by Copilot at 0afb117
This pull request adds WebRTC support for media streaming in the
Feed
andLiveFeed
components, and refactors the existing hooks for media players. It introduces a new hookuseWebRTCPlayer
and a new configuration optionuse_webrtc
. It also updates theuseMSEMediaPlayer
anduseHLSPlayer
hooks to have consistent interfaces and functionality.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 0afb117
webrtc-adapter
package as a dependency to enable consistent WebRTC API (link)use_webrtc
configuration option to enable or disable WebRTC streaming (link, link)useWebRTCPlayer
hook to stream media using WebRTC protocol (link)useMSEplayer
hook to simplify interface and handle stop request (link, link, link, link, link)useHLSPlayer
hook to return an emptystopStream
function (link)use_webrtc
option and device type inFeed.tsx
andLiveFeed.tsx
components (link, link, link, link, link, link)startStream
dependency fromuseEffect
hook inLiveFeed.tsx
component (link)