Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for webrtc stream #6457

Closed
wants to merge 3 commits into from
Closed

Conversation

sainak
Copy link
Member

@sainak sainak commented Oct 16, 2023

WHAT

🤖 Generated by Copilot at 0afb117

This pull request adds WebRTC support for media streaming in the Feed and LiveFeed components, and refactors the existing hooks for media players. It introduces a new hook useWebRTCPlayer and a new configuration option use_webrtc. It also updates the useMSEMediaPlayer and useHLSPlayer hooks to have consistent interfaces and functionality.

Proposed Changes

  • adds support for webrtc stream

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 0afb117

  • Add webrtc-adapter package as a dependency to enable consistent WebRTC API (link)
  • Add use_webrtc configuration option to enable or disable WebRTC streaming (link, link)
  • Add useWebRTCPlayer hook to stream media using WebRTC protocol (link)
  • Modify useMSEplayer hook to simplify interface and handle stop request (link, link, link, link, link)
  • Modify useHLSPlayer hook to return an empty stopStream function (link)
  • Switch between WebRTC and MSE/HLS players based on use_webrtc option and device type in Feed.tsx and LiveFeed.tsx components (link, link, link, link, link, link)
  • Remove unnecessary startStream dependency from useEffect hook in LiveFeed.tsx component (link)

@sainak sainak requested a review from a team October 16, 2023 12:43
@sainak sainak requested a review from a team as a code owner October 16, 2023 12:43
@sainak sainak requested a review from gigincg October 16, 2023 12:43
@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 11:56am

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5fbfa78
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/652fc7c560e95d000894fdcb
😎 Deploy Preview https://deploy-preview-6457--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sainak
Copy link
Member Author

sainak commented Oct 16, 2023

@cypress
Copy link

cypress bot commented Oct 16, 2023

20 failed tests on run #1431 ↗︎

20 0 0 59 Flakiness 0

Details:

add support for webrtc stream
Project: CARE Commit: 5fbfa785a0
Status: Failed Duration: 06:32 💡
Started: Oct 18, 2023 12:00 PM Ended: Oct 18, 2023 12:06 PM
Failed  patient_spec/patient_crud.cy.ts • 1 failed test

View Output Video

Test Artifacts
Patient Creation with consultation > Create a new patient with no consultation Test Replay Output Screenshots
Failed  assets_spec/assets_creation.cy.ts • 1 failed test

View Output Video

Test Artifacts
Asset > Verify asset creation fields throws error if empty Test Replay Output Screenshots
Failed  users_spec/user_crud.cy.ts • 2 failed tests

View Output Video

Test Artifacts
User management > create user Test Replay Output Screenshots
Edit User Profile & Error Validation > First name Field Updation qede8qobowj6suti7gw04l9wa Test Replay Output Screenshots
Failed  assets_spec/assets_manage.cy.ts • 1 failed test

View Output Video

Test Artifacts
Asset > Verify Asset Warranty Expiry Label Test Replay Output Screenshots
Failed  facility_spec/facility.cy.ts • 1 failed test

View Output Video

Test Artifacts
Facility Creation > Create a new facility Test Replay Output Screenshots

The first 5 failed specs are shown, see all 19 specs in Cypress Cloud.

Review all test suite changes for PR #6457 ↗︎

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 18, 2023
@github-actions
Copy link

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 18, 2023
@nihal467
Copy link
Member

@sainak most of the cypress are failing, can you check it

@nihal467 nihal467 added changes required cypress failed pull request with cypress test failure blocked labels Oct 25, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 27, 2023
@github-actions
Copy link

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

comment from @sainak : this pr is blocked, we need to asses the benefits of webrtc over existing services

@bodhish
Copy link
Member

bodhish commented Sep 20, 2024

Closing this PR due to lack of recent progress.

@sainak ping me if you are planing to work on this.

@bodhish bodhish closed this Sep 20, 2024
@bodhish bodhish deleted the sainak/feat/webrtc-stream branch December 1, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked changes required cypress failed pull request with cypress test failure merge conflict pull requests with merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants