Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICD-11 diagnosis cannot be both prov and final #6447

Closed
wants to merge 3 commits into from
Closed

ICD-11 diagnosis cannot be both prov and final #6447

wants to merge 3 commits into from

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Oct 13, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at be504af

The pull request enhances the diagnosis selection and validation features in the ConsultationForm component. It uses the DiagnosisSelectFormField component with some exclusions to avoid duplicate diagnoses, and adapts to the new ICD11DiagnosisModel fields.

Proposed Changes

  • Fixes ICD-11 (same diagnosis cant be both prov and final) #6366
  • When a diagnosis is selected as a final diagnosis, it must automatically get un-selected as a prov. diagnosis.
  • When a diagnosis is already marked as final diagnosis, Do NOT allow the user to select it as a provisional diagnosis.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at be504af

  • Exclude already selected diagnoses from provisional diagnosis field (link, link, link)
  • Update state reducer to handle changes in diagnosis fields (link)
  • Add console log for debugging errors in form submission (link)

@GokulramGHV GokulramGHV requested a review from a team October 13, 2023 13:05
@GokulramGHV GokulramGHV requested a review from a team as a code owner October 13, 2023 13:05
@GokulramGHV GokulramGHV requested a review from gigincg October 13, 2023 13:05
@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 6:39am

@netlify
Copy link

netlify bot commented Oct 13, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 289d89d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653a0991d5ad220008aee500
😎 Deploy Preview https://deploy-preview-6447--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GokulramGHV update the validations in the backend too

@GokulramGHV
Copy link
Member Author

@rithviknishad I've updated the validations in the backend. Pls review this ohcnetwork/care#1673

@nihal467
Copy link
Member

@GokulramGHV fix the backend failing test for reviewing the PR

@nihal467
Copy link
Member

LGTM

@rithviknishad
Copy link
Member

rithviknishad commented Oct 29, 2023 •
edited
Loading

@GokulramGHV marking it as do not merge as the model changes made in ohcnetwork/care#1690 will fix it.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

👋 Hi, @GokulramGHV,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg Awaiting requested review from gigincg

@rithviknishad rithviknishad Awaiting requested review from rithviknishad

Assignees
No one assigned
Labels
cypress passed do not merge merge conflict pull requests with merge conflict tested waiting for backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICD-11 (same diagnosis cant be both prov and final)
3 participants
@GokulramGHV @nihal467 @rithviknishad