Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date range end picker #6413

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix date range end picker #6413

merged 1 commit into from
Oct 6, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 6, 2023

Fixes #6414

WHAT

🤖 Generated by Copilot at c3592a7

Simplify and improve DateInputV2 component by using Popover and closing on date selection.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at c3592a7

  • Close date picker popover on date selection (link)
  • Remove unnecessary onClick and onBlur handlers from Popover.Button and input element (link, link)

@Ashesh3 Ashesh3 requested a review from a team October 6, 2023 12:34
@Ashesh3 Ashesh3 requested a review from a team as a code owner October 6, 2023 12:34
@Ashesh3 Ashesh3 requested a review from gigincg October 6, 2023 12:34
@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c3592a7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/651ffee6351a4200083d6f98
😎 Deploy Preview https://deploy-preview-6413--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 0:35am

@cypress
Copy link

cypress bot commented Oct 6, 2023

1 failed test on run #1376 ↗︎

1 77 0 0 Flakiness 0

Details:

Fix date range end picker
Project: CARE Commit: c3592a701c
Status: Failed Duration: 02:57 💡
Started: Oct 6, 2023 12:39 PM Ended: Oct 6, 2023 12:42 PM
Failed  cypress/e2e/patient_spec/patient_crud.cy.ts • 1 failed test

View Output Video

Test Artifacts
Patient Creation with consultation > Create a New consultation to existing patient Test Replay Output Screenshots

Review all test suite changes for PR #6413 ↗︎

@nihal467
Copy link
Member

nihal467 commented Oct 6, 2023

LGTM

@khavinshankar khavinshankar merged commit 6558eb7 into develop Oct 6, 2023
35 of 36 checks passed
@khavinshankar khavinshankar deleted the fix-date-inp branch October 6, 2023 15:48
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End date picker focus issue
3 participants