Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Create More: fix reset of is_working state #6398

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 4, 2023

WHAT

🤖 Generated by Copilot at d6af935

Fixed a bug in AssetCreate.tsx where the isWorking state was initialized with an empty string instead of undefined. This improves the clarity and correctness of the code.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at d6af935

  • Change the initial value of isWorking state to undefined instead of an empty string to avoid confusion and errors (link)

@rithviknishad rithviknishad requested a review from a team October 4, 2023 15:06
@rithviknishad rithviknishad requested a review from a team as a code owner October 4, 2023 15:06
@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 5:33am

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3ac7f19
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/651e4aa089f08d00092a5bbb
😎 Deploy Preview https://deploy-preview-6398--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Oct 4, 2023

Passing run #1361 ↗︎

0 78 0 0 Flakiness 0

Details:

Asset Create More: fix reset of `is_working` state
Project: CARE Commit: 3ac7f193e6
Status: Passed Duration: 03:07 💡
Started: Oct 5, 2023 5:37 AM Ended: Oct 5, 2023 5:40 AM

Review all test suite changes for PR #6398 ↗︎

@khavinshankar khavinshankar merged commit 07441ae into develop Oct 5, 2023
29 checks passed
@khavinshankar khavinshankar deleted the fix-6397 branch October 5, 2023 07:18
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset Create validation is not proper for "Working status" when doing "Create and add more"
3 participants