-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AMC Warranty filters and expiry labels for assets #6364
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
the above asset has a warranty (31/01/2024) and today's date is (03/10/2023), as per the issue, the label should be coming from 3 months, but the above asset has more than 3 months exactly saying and the expiring label is shown to this asset Note: if i make the warranty to any date in February, the warning is disappeared.
|
@GokulramGHV i have assigned you the cypress issue for this feature, work on it as a separate PR or along with this PR |
it is less than 3 months, and the alert is not working properly, make sure you cover all the edge cases, and mark it or testing |
@nihal467 the no. of days between today and 8th of january is 91 days, I'm considering 90 days to be 3 months. So that is the reason why it doesn't show the label |
LGTM, @GokulramGHV i have assigned you the cypress test related to this, you can create a separate PR for that |
WHAT
🤖 Generated by Copilot at e18d241
The pull request adds a new feature to manage assets by their warranty or AMC end of validity. It allows users to filter assets by date range, see the status of the warranty or AMC in a chip component, and export the filtered data. It modifies the files
AssetFilter.tsx
,AssetManage.tsx
, andAssetsList.tsx
to implement this feature.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at e18d241
AssetFilter.tsx
(link)AssetFilter.tsx
(link)AssetFilter.tsx
(link)AssetFilter.tsx
(link)AssetFilter.tsx
(link)AssetFilter.tsx
(link)AssetManage.tsx
(link)AssetManage.tsx
(link)AssetsList.tsx
(link)AssetsList.tsx
(link)AssetsList.tsx
(link)AssetsList.tsx
(link)AssetsList.tsx
(link)