Enable clearing 'referred to' in discharge modal #6337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #1304 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
LGTM |
khavinshankar
approved these changes
Sep 26, 2023
|
@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 7c387da
This pull request enhances the user interface and functionality of the discharge modal and the
AutoCompleteAsynccomponent. It fixes a bug in the facility selection, adds internationalization and validation support, and allows clearing the selected option. The changes affect the filesDischargeModal.tsxandAutoCompleteAsync.tsx.Proposed Changes
This PR resolves the issue #6301, where users were unable to clear the 'referred to' field in the discharge pop-up.
Previously, when discharging a patient and marking the reason for discharge as 'referred', users were unable to clear the selected hospital in the 'referred to' field. This behavior was inconsistent with the field's non-mandatory nature.
With this fix, users can now clear the 'referred to' field as expected. This change improves the user experience by providing the necessary flexibility in the discharge process.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖 Generated by Copilot at 7c387da
useTranslationhook andtfunction toAutoCompleteAsynccomponent to enable internationalization of text strings (link, link)requiredprop toAutoCompleteAsynccomponent to allow parent component to indicate mandatory or optional selection (link, link)AutoCompleteAsynccomponent when selection is not loading or required, and usetfunction to translate icon and tooltip text (link)optionLabelfunction ofAutoCompleteAsynccomponent to avoid errors when function is undefined or null (link)facilityvariable inDischargeModalcomponent from default object to undefined to avoid blank option in facility select component (link)handleFacilitySelectfunction inDischargeModalcomponent to handle null or undefined selection and set or nullreferred_toandreferred_to_externalfields ofpreDischargeFormstate accordingly (link)showAllandfreeTextofAutoCompleteAsynccomponent to use shorthand syntax without explicit values (link)