-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset Configure: Migrate useDispatch
to use useQuery
(inherently fixes camera not reloading on configure saved)
#6327
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
useDispatch
to use useQuery
(inherently fixes camera not reloading on configure saved)useDispatch
to use useQuery
(inherently fixes camera not reloading on configure saved)
Passing run #1298 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
LGTM |
@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
WHAT
🤖 Generated by Copilot at 9f62b97
Refactored and improved the
AssetConfigure
andONVIFCamera
components for managing and displaying asset data and configuration. Added type parameter for asset API route to enhance type safety.Proposed Changes
useDispatch
w.useQuery
/request
: Assets (src/Components/Assets/**
) #6326@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 9f62b97
AssetConfigure
component to useuseQuery
hook for fetching asset data (link, link, link, link)onUpdated
prop toONVIFCamera
component to trigger refetch of asset data in parent component (link, link, link, link)getAsset
route asAssetData
(link, link)