Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Configure: Migrate useDispatch to use useQuery (inherently fixes camera not reloading on configure saved) #6327

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 22, 2023

WHAT

🤖 Generated by Copilot at 9f62b97

Refactored and improved the AssetConfigure and ONVIFCamera components for managing and displaying asset data and configuration. Added type parameter for asset API route to enhance type safety.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 9f62b97

  • Refactor AssetConfigure component to use useQuery hook for fetching asset data (link, link, link, link)
  • Add optional onUpdated prop to ONVIFCamera component to trigger refetch of asset data in parent component (link, link, link, link)
  • Specify response type for getAsset route as AssetData (link, link)

@rithviknishad rithviknishad requested a review from a team September 22, 2023 12:11
@rithviknishad rithviknishad requested a review from a team as a code owner September 22, 2023 12:11
@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 0:21am

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a8c9a43
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/650d868c9daa770008d02af3
😎 Deploy Preview https://deploy-preview-6327--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad changed the title ONVIF Configure: Migrate useDispatch to use useQuery (inherently fixes camera not reloading on configure saved) Asset Configure: Migrate useDispatch to use useQuery (inherently fixes camera not reloading on configure saved) Sep 22, 2023
@cypress
Copy link

cypress bot commented Sep 22, 2023

Passing run #1298 ↗︎

0 75 0 0 Flakiness 0

Details:

Asset Configure: Migrate `useDispatch` to use `useQuery` (inherently fixes camer...
Project: CARE Commit: a8c9a437f8
Status: Passed Duration: 02:54 💡
Started: Sep 22, 2023 12:24 PM Ended: Sep 22, 2023 12:27 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit fee0648 into develop Sep 22, 2023
29 checks passed
@khavinshankar khavinshankar deleted the fix-assetconfig-reload-onsave branch September 22, 2023 13:56
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera View does not reload on new configuration saved
3 participants