Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for archiving medicine administrations #6311

Closed
wants to merge 3 commits into from

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 20, 2023

WHAT

🤖 Generated by Copilot at fa76e7f

This pull request adds a new feature to show a timeline of events for each prescription in the medicine administration module. It also improves the Redux actions and the API integration for managing and archiving administrations. It modifies the PrescriptionAdministrationsTable, actions, api, and models modules, and creates a new component MedicineAdministrationEventsTimeline.

Required Backends

Proposed Changes

image image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at fa76e7f

  • Add a new component MedicineAdministrationEventsTimeline to render a timeline of events for a prescription (link)
  • Update the type definition of MedicineAdministrationRecord to include archiving properties and make some properties required (link)
  • Import the new component into PrescriptionAdministrationsTable and use it to show the history of events for each prescription in a modal dialog (link, link, link)
  • Add a property archived to the PrescriptionRow component state to filter out archived administrations from the table view (link)
  • Fix a bug where the PrescriptionRow component was rendered outside of a table row element (link)
  • Modify the AdministrationCell component to simplify the logic for discontinued prescriptions and render a stack of icons for multiple administrations or discontinuation (link)
  • Remove the commented out code and the tooltip text from the AdministrationCell component, as the details are shown in the timeline component (link, link)
  • Update the PrescriptionActions object to make the obj parameter of the administer action partial and add a new action archive for archiving an administration (link, link)
  • Add a new route archiveAdministration to the routes object for the API endpoint for archiving an administration (link)

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 5:18am

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 153164e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/651cf58fe91f570008daa271
😎 Deploy Preview https://deploy-preview-6311--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 20, 2023

Passing run #1351 ↗︎

0 78 0 0 Flakiness 0

Details:

Adds support for archiving medicine administrations
Project: CARE Commit: 153164efb2
Status: Passed Duration: 02:57 💡
Started: Oct 4, 2023 5:22 AM Ended: Oct 4, 2023 5:25 AM

Review all test suite changes for PR #6311 ↗︎

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 21, 2023
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad added needs testing and removed merge conflict pull requests with merge conflict labels Sep 27, 2023
@rithviknishad rithviknishad marked this pull request as ready for review September 27, 2023 09:53
@rithviknishad rithviknishad requested a review from a team September 27, 2023 09:53
@rithviknishad rithviknishad requested a review from a team as a code owner September 27, 2023 09:53
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 4, 2023
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 4, 2023
@nihal467
Copy link
Member

nihal467 commented Oct 4, 2023

@rithviknishad
image

currently, only the medicine administration is getting archived, but co-related note is still active in the timeline, should be keep it or change it { Discussion on EOD }

other than that, PR looks good to me

@rithviknishad
Copy link
Member Author

As per discussion, the administration comment should be shown along with the administration event itself instead of a seperate event. And it should be greyed out too.

@rithviknishad
Copy link
Member Author

Closing as continued in #6396

@rithviknishad rithviknishad deleted the medicine-administrations/archive branch February 19, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing waiting for related PR a co-related detail PR is under construction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for archiving Medicine Administration Record
2 participants