Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cam reset #6286

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Cam reset #6286

merged 6 commits into from
Sep 15, 2023

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Sep 14, 2023

WHAT

🤖 Generated by Copilot at 6292499

This pull request enhances the camera control and streaming features in the Feed component and the useHLSPlayer hook. It reduces unnecessary data fetching, avoids caching problems, and handles edge cases more gracefully.

Proposed Changes

  • when the camera is reloaded don't reset the preset.
  • added auto reset for feed when delay is greater than 5seconds

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 6292499

  • Append timestamp to HLS stream url to avoid caching issues and ensure freshness (link)
  • Add condition to check if currentPreset is defined before setting loading state and fetching preset data in Feed component (link)
  • Remove redundant condition for iOS and reset button in renderButton function in Feed component (link)

@khavinshankar khavinshankar requested a review from a team September 14, 2023 05:30
@khavinshankar khavinshankar requested a review from a team as a code owner September 14, 2023 05:30
@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 0:30am

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b3eb53e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65044e43acf6bf00081bf9f3
😎 Deploy Preview https://deploy-preview-6286--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@khavinshankar khavinshankar added the P1 breaking issue or vital feature label Sep 14, 2023
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interesting hack looks good to me!

@cypress
Copy link

cypress bot commented Sep 14, 2023

Passing run #1248 ↗︎

0 71 0 0 Flakiness 0

Details:

Merge 6292499 into c5f3b79...
Project: CARE Commit: e7c9034d66 ℹ️
Status: Passed Duration: 07:11 💡
Started: Sep 14, 2023 5:35 AM Ended: Sep 14, 2023 5:42 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Sep 15, 2023

2 failed tests on run #1261 ↗︎

2 69 0 0 Flakiness 0

Details:

Cam reset
Project: CARE Commit: 4719be97d2
Status: Failed Duration: 03:18 💡
Started: Sep 15, 2023 11:41 AM Ended: Sep 15, 2023 11:44 AM
Failed  cypress/e2e/resource_spec/resources.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Resource Page > Update the status of resource Test Replay Output Screenshots
Resource Page > Post comment for a resource Test Replay Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@nihal467
Copy link
Member

LGTM

@gigincg gigincg merged commit 0167315 into develop Sep 15, 2023
22 checks passed
@github-actions
Copy link

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the cam-reset branch September 15, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants