Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix goBack precedence #6285

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fix goBack precedence #6285

merged 2 commits into from
Sep 14, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 13, 2023

WHAT

🤖 Generated by Copilot at 09373b6

Fixed a bug in the goBack hook that caused incorrect navigation behavior in some scenarios. Refactored the logic of the hook to use the app history stack more reliably.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 09373b6

  • Fix a bug in the goBack function of the useAppHistory hook that caused the fallback url to override the previous page in some cases (link)

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 5:06pm

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c9f6054
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6501ebee1ef95f0008fb543d
😎 Deploy Preview https://deploy-preview-6285--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 13, 2023

Passing run #1244 ↗︎

0 71 0 0 Flakiness 0

Details:

Merge c9f6054 into cc6b570...
Project: CARE Commit: d796c1c694 ℹ️
Status: Passed Duration: 10:25 💡
Started: Sep 13, 2023 5:12 PM Ended: Sep 13, 2023 5:22 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@rithviknishad rithviknishad marked this pull request as ready for review September 13, 2023 17:08
@rithviknishad rithviknishad requested a review from a team September 13, 2023 17:08
@rithviknishad rithviknishad requested a review from a team as a code owner September 13, 2023 17:08
@rithviknishad rithviknishad added the P1 breaking issue or vital feature label Sep 13, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 2956fa9 into develop Sep 14, 2023
28 checks passed
@khavinshankar khavinshankar deleted the fix-back-button branch September 14, 2023 03:12
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed P1 breaking issue or vital feature tested
Projects
None yet
3 participants