Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled asset config button for users other than state and district admin #6259

Merged

Conversation

thtauhid
Copy link
Contributor

@thtauhid thtauhid commented Sep 11, 2023

WHAT

🤖 Generated by Copilot at 3961e13

Enhance role-based authorization for asset management using RoleBasedComponent. Restrict access to buttons in AssetManage.tsx based on user roles.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 3961e13

  • Import AuthorizeFor component to use for conditional rendering of buttons based on user roles (link)
  • Replace authorizeFor prop of Button component with AuthorizeFor component and an array of user roles to restrict access to configure asset button to only district and state admins (link)

@thtauhid thtauhid requested a review from a team September 11, 2023 05:50
@thtauhid thtauhid requested a review from a team as a code owner September 11, 2023 05:50
@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 5:51am

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3961e13
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64feaaaf8aeeda0008377437
😎 Deploy Preview https://deploy-preview-6259--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 7cda789 into ohcnetwork:develop Sep 11, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Asset Configuration option from Doctors and staff user type
3 participants