Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fullscreen button for IOS #6225

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fix fullscreen button for IOS #6225

merged 2 commits into from
Sep 7, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 5, 2023

WHAT

🤖 Generated by Copilot at f692c20

Fix fullscreen mode on Safari browsers by using webkit-specific methods. Refactor setFullscreen function in useFullscreen hook to improve readability and compatibility.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at f692c20

  • Fix fullscreen mode on Safari browsers by using webkit-specific methods (link)
    • Modify setFullscreen function to use helper functions instead of directly calling standard methods (link)

@Ashesh3 Ashesh3 requested a review from a team September 5, 2023 11:42
@Ashesh3 Ashesh3 requested a review from a team as a code owner September 5, 2023 11:42
@Ashesh3 Ashesh3 requested a review from mathew-alex September 5, 2023 11:42
@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 2:39pm

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ef0acbe
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64f88ef384a47600086e4c78
😎 Deploy Preview https://deploy-preview-6225--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Sep 7, 2023

LGTM

@khavinshankar khavinshankar merged commit fe36bd0 into develop Sep 7, 2023
24 checks passed
@khavinshankar khavinshankar deleted the issue-6181 branch September 7, 2023 09:48
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera Feed Buttons are not working properly in iphone
3 participants