Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily expose abdm health facility config directly #6197

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Sep 1, 2023

WHAT

🤖 Generated by Copilot at 3eaf27f

This pull request simplifies and refactors the code for updating and configuring health facilities. It removes an unnecessary feature flag and uses optional chaining to handle API responses.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 3eaf27f

  • Remove the use of the config.enable_abdm flag and the useConfig hook from the UpdateFacilityMiddleware component (link, link, link)
  • Always render the ConfigureHealthFacility component after the form in the UpdateFacilityMiddleware.tsx file (link)
  • Refactor the status check of the health facility API response to use optional chaining in the ConfigureHealthFacility.tsx file (link)

@khavinshankar khavinshankar requested a review from a team September 1, 2023 04:14
@khavinshankar khavinshankar requested a review from a team as a code owner September 1, 2023 04:14
@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:51am

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f9f152d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64f6f9feba99fa000734d223
😎 Deploy Preview https://deploy-preview-6197--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Sep 1, 2023
@khavinshankar
Copy link
Member Author

@aparnacoronasafe Even if the health facility configuration is directly exposed, we still need production keys for the linking of the health facility to work, because when we link a health facility, we are calling ABDM bridge API in the backend which requires prod keys.

Is this pr still relevant?

@khavinshankar khavinshankar added P1 breaking issue or vital feature and removed cypress failed pull request with cypress test failure labels Sep 5, 2023
@khavinshankar
Copy link
Member Author

  • Separated out linking health facility in care and registering it as a service in ABDM
  • Added UI to show if the health facility is registered as a service
image

@nihal467
Copy link
Member

nihal467 commented Sep 7, 2023

LGTM

@gigincg gigincg merged commit 4519b08 into develop Sep 8, 2023
26 checks passed
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the hf-expose branch September 8, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants