Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed popup scrolling and closing problem #6169

Closed
wants to merge 5 commits into from
Closed

fixed popup scrolling and closing problem #6169

wants to merge 5 commits into from

Conversation

sghosh28
Copy link

Proposed Changes

@rithviknishad @nihal467

HOW

  • Pop-up may close when clicked outside.
    Used onClick event listener to close popup when clicked outside
  • Pop-up may scroll along with the page.
    Made pop-up relative to a parent body and used getBoundingClientRect to get X Y value for popup relative to parent.

@sghosh28 sghosh28 requested a review from a team August 28, 2023 10:16
@sghosh28 sghosh28 requested a review from a team as a code owner August 28, 2023 10:16
@sghosh28 sghosh28 requested a review from gigincg August 28, 2023 10:16
@vercel
Copy link

vercel bot commented Aug 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 1:48am

@netlify
Copy link

netlify bot commented Aug 28, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 11c3be3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64f5372bbfe46a00085147ad
😎 Deploy Preview https://deploy-preview-6169--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

image
  • When I type something on width and height, it auto-closes suddenly, and the pop-up is not working properly

@nihal467
Copy link
Member

@sghosh28

@sghosh28
Copy link
Author

image * When I type something on width and height, it auto-closes suddenly, and the pop-up is not working properly

Hello @nihal467 ,

Could you please guide me on how to access the popup for editing details? I'm looking to understand how to address the issue.

Thank you!

@sghosh28
Copy link
Author

@sghosh28

Found the issue, working on it

@sghosh28
Copy link
Author

@nihal467
Done with new changes

@nihal467
Copy link
Member

nihal467 commented Sep 5, 2023

@sghosh28
image

  • now the dropdowns are not closing post selecting an option

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 13, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Sep 20, 2023
@gigincg gigincg reopened this Aug 22, 2024
@gigincg
Copy link
Member

gigincg commented Aug 22, 2024

Closing the issue, since the PressureSore component has been rebuilt in TypeScript, making this PR unsalvageable

@gigincg gigincg closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
stale test failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pressure pop-up not scrolling along with page
4 participants
@sghosh28 @nihal467 @gigincg @rithviknishad