Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for facility.cy.ts #6107

Closed
wants to merge 7 commits into from

Conversation

ShivamJhaa
Copy link
Contributor

@ShivamJhaa ShivamJhaa commented Aug 19, 2023

WHAT

🤖 Generated by Copilot at bd11d35

The pull request improves the testing and code quality of the facility management features. It refactors the facility_spec tests into separate files and uses page objects to simplify the test logic. It also adds new test cases and methods for various facility actions and validations. It makes minor changes to the FacilityHome component and the LoginPage page object to support the testing.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at bd11d35

  • Refactor the facility-related Cypress tests to use the FacilityPage page object and consolidate them in the facility.cy.ts file (link, link, link, link)
  • Add new Cypress test cases for configuring the middleware address, creating a resource request, and deleting a facility for an existing facility in the Facility Creation suite (link)
  • Import the cy object from the local-cypress module in the FacilityPage and LoginPage page objects, to use the custom wrapper for the Cypress commands (link, link)
  • Add new methods to the FacilityPage page object for clicking on the manage facility dropdown options and performing the actions and assertions for the new test cases (link, link)
  • Remove the unused useSelector import from the FacilityHome component (link)
  • Add id attributes to the Resource Request and Delete Facility options in the manage facility dropdown, to make them easier to select in the Cypress tests (link, link)

@ShivamJhaa ShivamJhaa requested a review from a team August 19, 2023 04:40
@ShivamJhaa ShivamJhaa requested a review from a team as a code owner August 19, 2023 04:40
@ShivamJhaa ShivamJhaa requested a review from bodhish August 19, 2023 04:40
@vercel
Copy link

vercel bot commented Aug 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 10:45am

@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f15c85d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64f5b51f3005d60008b9bc2d
😎 Deploy Preview https://deploy-preview-6107--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShivamJhaa ShivamJhaa changed the title Added test for resource.cy.ts Added test for facility.cy.ts Aug 19, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 24, 2023
@github-actions
Copy link

👋 Hi, @ShivamJhaa,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict pull requests with merge conflict stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for facility.cy.ts
1 participant