cleanup fireRequests and remove axios #6003

sainak · 2023-08-04T16:21:34Z

WHAT

`🤖 Generated by Copilot at ca617a1`

This pull request replaces axios with fetch for making HTTP requests throughout the codebase, and removes the axios dependency from the package.json file. This improves the performance, compatibility, and consistency of the HTTP requests and reduces the code complexity. It also fixes some minor issues with the routes and authentication in the api.tsx file.

Proposed Changes

Replace axios with native fetch

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

HOW

`🤖 Generated by Copilot at ca617a1`

Remove axios dependency and import statements from various files (link, link, link, link, link, link, link, link)
Replace axios with fetch for making HTTP requests in various files, using custom helper functions and adjusting the request parameters, headers, and body as needed (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
Remove unused or redundant actions and error checks related to axios (link, link)
Add trailing slashes to various routes in api.tsx to match the backend expectations (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
Add a noAuth flag to the token_refresh route in api.tsx to indicate that it does not require authentication (link)

vercel · 2023-08-04T16:21:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 28, 2023 0:02am

netlify · 2023-08-04T16:21:42Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`fee12b3`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/65156b0fe776980008a7a0e9
😎 Deploy Preview	https://deploy-preview-6003--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nihal467 · 2023-08-09T11:20:30Z

@sainak check the cypress issue

khavinshankar · 2023-08-09T11:38:20Z

@rithviknishad @Ashesh3 can you please review this pr once

src/Redux/fireRequest.tsx

github-actions · 2023-08-16T09:03:57Z

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions · 2023-08-24T04:13:28Z

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions · 2023-08-31T04:13:59Z

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

nihal467 · 2023-10-03T00:00:42Z

@sainak

https://deploy-preview-6003--care-net.netlify.app/facility/45d45bb6-c48e-4883-984d-ac602ef7df1e/patient/5ea5550d-acc3-426e-888f-42f0ed58b705/consultation/debbce92-7670-45c0-93e4-82cd92241a6c/feed

when I try to move a camera to a fixed preset, the moving symbol stuck in the loading state post moving to the preset position. In existing staging, there is no issue like that.

Note: This issue was only observed while moving to a preset, but manual controls are working fine

unable to upload a facility cover image

critical care page is not at all loading

https://deploy-preview-6003--care-net.netlify.app/facility/45d45bb6-c48e-4883-984d-ac602ef7df1e/patient/5ea5550d-acc3-426e-888f-42f0ed58b705/consultation/debbce92-7670-45c0-93e4-82cd92241a6c/daily_rounds/4a42ec26-3dd0-4998-8b6f-4fbd9ba96e27/update

CC: @rithviknishad

github-actions · 2023-10-04T03:42:34Z

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions · 2023-10-11T04:14:20Z

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions · 2023-10-18T04:14:24Z

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

nihal467 · 2023-10-25T06:19:27Z

@sainak any ETD for this PR status, as its been stale with no activity for 3 weeks ?

github-actions · 2023-11-03T04:14:21Z

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

github-actions · 2023-11-11T04:14:15Z

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

Ashesh3 · 2023-12-05T17:48:19Z

@sainak any ETD for this PR status, as its been stale with no activity for 3 weeks ?

^ @sainak

cc: @nihal467

cleanup fireRequests and remove axios

ca617a1

sainak requested a review from a team August 4, 2023 16:21

sainak requested a review from a team as a code owner August 4, 2023 16:21

sainak requested a review from gigincg August 4, 2023 16:21

github-actions bot added the cypress failed pull request with cypress test failure label Aug 4, 2023

sainak mentioned this pull request Aug 4, 2023

Reduce bundle size #6004

Open

13 tasks

Merge branch 'develop' into sainak/replace-axios

644553d

vercel bot temporarily deployed to Preview August 8, 2023 14:46 Inactive

sainak requested review from rithviknishad, khavinshankar and Ashesh3 August 9, 2023 10:03

Merge branch 'develop' into sainak/replace-axios

f6db779

vercel bot temporarily deployed to Preview August 9, 2023 10:39 Inactive

Ashesh3 approved these changes Aug 9, 2023

View reviewed changes

rithviknishad approved these changes Aug 9, 2023

View reviewed changes

rithviknishad requested changes Aug 11, 2023

View reviewed changes

src/Redux/fireRequest.tsx Outdated Show resolved Hide resolved

rithviknishad added the changes required label Aug 11, 2023

github-actions bot added the merge conflict pull requests with merge conflict label Aug 16, 2023

github-actions bot added the stale label Aug 24, 2023

github-actions bot closed this Aug 31, 2023

rithviknishad mentioned this pull request Sep 12, 2023

Implements useQuery & request data fetching utilities (used in Location Management page) #6269

Merged

6 tasks

rithviknishad reopened this Sep 14, 2023

github-actions bot removed the stale label Sep 15, 2023

avoid auth header for password reset

7222cb4

vercel bot temporarily deployed to Preview September 28, 2023 04:11 Inactive

fix duplicate slash in path

c0a4d38

vercel bot temporarily deployed to Preview September 28, 2023 04:35 Inactive

sainak added cypress failed pull request with cypress test failure and removed Cypress Test Pending The Cypress test are to be verified labels Sep 28, 2023

fix trailing slash

fee12b3

vercel bot temporarily deployed to Preview September 28, 2023 12:02 Inactive

rithviknishad added cypress passed and removed cypress failed pull request with cypress test failure labels Sep 28, 2023

nihal467 added test failed and removed needs testing labels Oct 3, 2023

github-actions bot added the merge conflict pull requests with merge conflict label Oct 4, 2023

github-actions bot added the stale label Oct 11, 2023

github-actions bot closed this Oct 18, 2023

sainak reopened this Oct 18, 2023

github-actions bot removed the stale label Oct 19, 2023

github-actions bot added the stale label Nov 3, 2023

github-actions bot closed this Nov 11, 2023

sainak deleted the sainak/replace-axios branch December 5, 2023 19:25

sainak restored the sainak/replace-axios branch December 5, 2023 19:26

bodhish deleted the sainak/replace-axios branch December 1, 2024 08:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cleanup fireRequests and remove axios #6003

cleanup fireRequests and remove axios #6003

sainak commented Aug 4, 2023 •

edited by ghost

Loading

vercel bot commented Aug 4, 2023 •

edited

Loading

netlify bot commented Aug 4, 2023 •

edited

Loading

nihal467 commented Aug 9, 2023

khavinshankar commented Aug 9, 2023

github-actions bot commented Aug 16, 2023

github-actions bot commented Aug 24, 2023

github-actions bot commented Aug 31, 2023

nihal467 commented Oct 3, 2023 •

edited

Loading

github-actions bot commented Oct 4, 2023

github-actions bot commented Oct 11, 2023

github-actions bot commented Oct 18, 2023

nihal467 commented Oct 25, 2023

github-actions bot commented Nov 3, 2023

github-actions bot commented Nov 11, 2023

Ashesh3 commented Dec 5, 2023

cleanup fireRequests and remove axios #6003

cleanup fireRequests and remove axios #6003

Conversation

sainak commented Aug 4, 2023 • edited by ghost Loading

WHAT

🤖 Generated by Copilot at ca617a1

Proposed Changes

Merge Checklist

HOW

🤖 Generated by Copilot at ca617a1

vercel bot commented Aug 4, 2023 • edited Loading

netlify bot commented Aug 4, 2023 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

nihal467 commented Aug 9, 2023

khavinshankar commented Aug 9, 2023

github-actions bot commented Aug 16, 2023

github-actions bot commented Aug 24, 2023

github-actions bot commented Aug 31, 2023

nihal467 commented Oct 3, 2023 • edited Loading

github-actions bot commented Oct 4, 2023

github-actions bot commented Oct 11, 2023

github-actions bot commented Oct 18, 2023

nihal467 commented Oct 25, 2023

github-actions bot commented Nov 3, 2023

github-actions bot commented Nov 11, 2023

Ashesh3 commented Dec 5, 2023

sainak commented Aug 4, 2023 •

edited by ghost

Loading

`🤖 Generated by Copilot at ca617a1`

`🤖 Generated by Copilot at ca617a1`

vercel bot commented Aug 4, 2023 •

edited

Loading

netlify bot commented Aug 4, 2023 •

edited

Loading

nihal467 commented Oct 3, 2023 •

edited

Loading