-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consultationDetails.tsx file broken down into smaller components fixes #5830 #5838
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
👋 Hi, @nazrul7711, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
hey @rithviknishad kindly review pr i have resolved the merge conflicts |
@rithviknishad can you review this again |
@nazrul7711 did you forget to push your changes before you requested review? |
hey @rithviknishad I think i have messed sth in pr, its not allowing me to push down changes m closing this one and making a fresh PR |
WHAT
🤖 Generated by Copilot at 37ce728
The pull request adds several new components to the
src/Components/Facility
directory, each corresponding to a different tab for displaying consultation data. The components use a common interface defined insrc/Common/constants.tsx
to receive props from the parent component. The components also import and render various plot, table, and file upload components from other directories. The purpose of the changes is to enhance the user interface and functionality of the consultation feature.The task was to break ConsultationDetails.tsx files into smaller components.
Proposed Changes
I made the following components.
ConsultationDetails.tsx
#5830@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 37ce728
defined ConsultationTabProps in common/constanct.tsx then I broke consultationDetail.tsx into smaller components . All the component logic which was based on condition tab==="condition" was moved to a separate component , then I defined a object name CONSULTATION_TAB where I defined the key as the "condition" and the value as those components and instead of conditional rendering I used const SelectedTab = CONSULTATION_TAB[tab] to render a single component depending upon the tab selected.