-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Page Component to make padding across pages to be consistent #4584
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for care-net failed.
|
👋 Hi, @GokulramGHV, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
👋 Hi, @GokulramGHV, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GokulramGHV this would be hard to review + I'm pretty sure the merge conflicts would never settle for this PR since there'll always be PRs that'll be modifying the contents of the children of the page.
Ideally what should have been done is, to implement the Page
component in one PR and use it in one place so that it can be tested. Once tested and merged, make multiple parallel PRs that use the new Page component for all the different pages.
This would be easier to review + easier to deal with merge conflicts.
cc: @khavinshankar
@rithviknishad Hey, that's actually a great idea! I'll close this pr and make a new one just with the |
Proposed Changes
Page
component to make padding across pages consistent #4375@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist