Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message when camera is offline #4575

Closed
wants to merge 3 commits into from
Closed

Conversation

khavinshankar
Copy link
Member

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team January 13, 2023 10:09
@khavinshankar khavinshankar requested a review from a team as a code owner January 13, 2023 10:09
@khavinshankar khavinshankar requested a review from gigincg January 13, 2023 10:09
@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 6:36am

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6387b97
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64c9f919c3d00c0008bc8887
😎 Deploy Preview https://deploy-preview-4575--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jan 13, 2023
@nihal467
Copy link
Member

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 24, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Feb 1, 2023
@nihal467 nihal467 reopened this Feb 17, 2023
@nihal467
Copy link
Member

@khavinshankar can you check this again

@github-actions github-actions bot removed the stale label Feb 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

@khavinshankar
image

https://deploy-preview-4575--care-net.netlify.app/facility/1fabc5fb-d96d-455a-ab61-53e6e0483cbc/patient/dda0caa4-a52c-49cd-9dd3-7fe8093aaa76/consultation/3e0a9c49-5148-4669-8d46-e3117d0987cf/feed

when the configuration is wrong, and it doesn't have feed coming into the patient consultation page, the screen goes black, not show any status

@khavinshankar
Copy link
Member Author

image

@nihal467 can you retest this with a hard refresh or in incognito, it's working on my end.

@khavinshankar khavinshankar removed test failed cypress failed pull request with cypress test failure labels Mar 6, 2023
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@nihal467
Copy link
Member

nihal467 commented Aug 2, 2023

@khavinshankar
image

can you check the PR, I am not getting offline error

@khavinshankar
Copy link
Member Author

@nihal467 About the Offline status, we won't be able to see that status because the feed will always try to reconnect, this is an intentional behavior.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 11, 2023
@github-actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

already solved in PR #6408

@nihal467 nihal467 closed this Oct 16, 2023
@rithviknishad rithviknishad deleted the fix#4559 branch December 1, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed merge conflict pull requests with merge conflict needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Error Messages for Camera Feed
2 participants