Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AccordionV2 and CollapseV2 components to replace MUI's Accordion and Collapse components #3762

Merged
merged 7 commits into from
Oct 26, 2022
Merged

Added AccordionV2 and CollapseV2 components to replace MUI's Accordion and Collapse components #3762

merged 7 commits into from
Oct 26, 2022

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Oct 16, 2022 •
edited
Loading

fixes #3763

Proposed Changes

  • Added AccordionV2 and CollapseV2 components
  • Replaced all code where the MUI's Accordion was used to AccordionV2 Component.
  • Replaced all code where the MUI's Collapse was used to CollapseV2 Component.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@GokulramGHV GokulramGHV requested a review from a team October 16, 2022 04:55
@GokulramGHV GokulramGHV requested a review from a team as a code owner October 16, 2022 04:55
@netlify
Copy link

netlify bot commented Oct 16, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6d17f57
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/634b8eae3fd58100082f3a13
😎 Deploy Preview https://deploy-preview-3762--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 16, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f8bf2d7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6353635d7cd2820008bb1ff0
😎 Deploy Preview https://deploy-preview-3762--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@GokulramGHV
Copy link
Member Author

Part of #3742

@GokulramGHV GokulramGHV changed the title Added AccordionTW component to replace MUI's Accordion component Added AccordionV2 and CollapseV2 components to replace MUI's Accordion and Collapse components Oct 16, 2022
rithviknishad
rithviknishad approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) LGTM

@rithviknishad
Copy link
Member

@nihal467 can this be tested ASAP? required by #3744

@nihal467
Copy link
Member

nihal467 commented Oct 17, 2022 •
edited
Loading

@GokulramGHV @rithviknishad there is lot of white spacing and alignment issue occurring due to this PR when compared to the existing staging

image

  • the current address is changed from the row of gender to the row of permanent address. it is breaking the alignment of the whole personal detail page compared to existing staging

image

  • the health details alignment is changed from the existing staging, and there is a lot of white space been wasted
  • some of the options are not been visible in normal view

@nihal467
Copy link
Member

@GokulramGHV
image

health section is completely breaking

@github-actions
Copy link

👋 Hi, @GokulramGHV,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 20, 2022
@GokulramGHV GokulramGHV added needs testing and removed test failed merge conflict pull requests with merge conflict labels Oct 21, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

tested

@khavinshankar khavinshankar merged commit d3506fb into ohcnetwork:develop Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
good to merge peer-reviewed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tailwind Component: Collapse (Accordion)
4 participants
@GokulramGHV @rithviknishad @nihal467 @khavinshankar