Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add bed notification #8632

Merged
merged 8 commits into from
Oct 2, 2024
Merged

fix: add bed notification #8632

merged 8 commits into from
Oct 2, 2024

Conversation

AdityaJ2305
Copy link
Contributor

Fixes #8627

  • Added a ternary operator to check no. of beds added and display the notification as per no. of beds selected

video demo:

Screen.Recording.2024-09-26.at.11.38.05.AM.mp4
  • Reviewers
    @ohcnetwork/care-fe-code-reviewers
    @nihal467

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@AdityaJ2305 AdityaJ2305 requested a review from a team as a code owner September 26, 2024 06:15
@netlify Netlify
Copy link

netlify bot commented Sep 26, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 14bda20
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66fc3d34fa05940008082cd4
😎 Deploy Preview https://deploy-preview-8632--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep representable texts in en locale files using useTranslations.

@rithviknishad rithviknishad mentioned this pull request Sep 26, 2024
Closed
6 tasks
rithviknishad
rithviknishad approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

LGTM

bodhish
bodhish requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @rithviknishad

src/Components/Facility/AddBedForm.tsx Outdated Show resolved Hide resolved
@khavinshankar
Copy link
Member

@AdityaJ2305 can you make the necessary changes

@AdityaJ2305
Copy link
Contributor Author

Yes by EOD

@AdityaJ2305
Copy link
Contributor Author

@bodhish @rithviknishad Should we display 4 Beds created successfully (with the count) or keep the previous format, Beds created successfully ?

@rithviknishad
Copy link
Member

Let's keep the count

bodhish
bodhish approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodhish bodhish merged commit ed31b71 into ohcnetwork:develop Oct 2, 2024
21 of 23 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

@AdityaJ2305 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish bodhish approved these changes

@rithviknishad rithviknishad Awaiting requested review from rithviknishad

Assignees
No one assigned
Labels
hacktoberfest-accepted tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify bed creation notification to show proper action related notification
5 participants
@AdityaJ2305 @nihal467 @khavinshankar @rithviknishad @bodhish