Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: Oversized cover image in facility page #7830

Conversation

Aryanshu919
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

[ ] Add specs that demonstrate or test a new feature.
Update [product documentation] (https://docs.coronasafe.network/coronasafe-care-documentation/architecture/architecture-and-layering-of-care).
Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

@Aryanshu919 Aryanshu919 requested a review from a team as a code owner May 15, 2024 18:50
Copy link

vercel bot commented May 15, 2024

@Aryanshu919 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3647d77
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/664e05c5f20a5d000953828e
😎 Deploy Preview https://deploy-preview-7830--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@@ -121,7 +121,7 @@ const CoverImageEditModal = ({
Success({ msg: "Cover image updated." });
} else {
Notification.Error({
msg: "Something went wrong!",
msg: "Oops! Facility cover image is too large. Please use a smaller size image.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aryanshu919

There could be other possibilities where this API can error out i.e., eg: when an SVG file is uploaded, the API errors out, but still file too large message would be shown.

For the issue #7661, make a backend fix where the respective error message is sent based on the actual issue and then show the error message send from the backend here

Copy link

github-actions bot commented Jun 5, 2024

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 5, 2024
Copy link

Hi, @coronasafe/care-frontend-maintainers, This PR has been automatically closed due to inactivity. Thank you for your contributions. Feel free to re-open the PR.

@github-actions github-actions bot closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Proper notification for Oversized cover image in facility page
3 participants