Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with negative value checks for nullable fields #7775

Merged
merged 1 commit into from
May 8, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented May 8, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner May 8, 2024 08:05
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 8:05am

Copy link

netlify bot commented May 8, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c8fb077
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/663b32516af6290008ea89a1
😎 Deploy Preview https://deploy-preview-7775--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented May 8, 2024

Passing run #2474 ↗︎

0 123 0 0 Flakiness 0

Details:

Fixes issue with negative value checks for nullable fields
Project: CARE Commit: c8fb077ead
Status: Passed Duration: 02:56 💡
Started: May 8, 2024 8:10 AM Ended: May 8, 2024 8:13 AM

Review all test suite changes for PR #7775 ↗︎

@nihal467
Copy link
Member

nihal467 commented May 8, 2024

LGTM

@khavinshankar khavinshankar merged commit 12b4933 into develop May 8, 2024
68 checks passed
@khavinshankar khavinshankar deleted the fixes-issue-with-negative-value-validation branch May 8, 2024 08:25
Copy link

github-actions bot commented May 8, 2024

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants